only initializes vfs when deprecated prop is set #6097
Merged
+18
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When the property `general.vfs.classpaths` was not set VFS was still unnecessarily initialized. Modified to only initialized VFS when the property is actually set. Tested locally by setting `general.vfs.classpaths=`, `general.dynamic.classpaths=`, `general.context.class.loader.factory=TestCL`. Where TestCL is a classloader that does nothing. When all of these are set did not see VFS create anything in local filesystem. Had to set some props to empty string because mini accumulo would set them otherwise. Also added some debug logging if VFS was initialized and did not see that. Removed that logging from these changes.
keith-turner
commented
Jan 29, 2026
| synchronized (lock) { | ||
| if (loader == null) { | ||
|
|
||
| FileSystemManager vfs = generateVfs(); |
Contributor
Author
There was a problem hiding this comment.
The main thing this PR is doing is avoiding always calling this.
dlmarion
approved these changes
Jan 29, 2026
Contributor
dlmarion
left a comment
dlmarion
left a comment
There was a problem hiding this comment.
This looks correct. ITs should confirm.
Contributor
Author
|
successfully ran |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When the property
general.vfs.classpathswas not set VFS was still unnecessarily initialized. Modified to only initialized VFS when the property is actually set.Tested locally by setting
general.vfs.classpaths=,general.dynamic.classpaths=,general.context.class.loader.factory=TestCL. Where TestCL is a classloader that does nothing. When all of these are set did not see VFS create anything in local filesystem. Had to set some props to empty string because mini accumulo would set them otherwise. Also added some debug logging if VFS was initialized and did not see that. Removed that logging from these changes.